[FIX] Chats holds to load history for some time #26425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipemarins
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #26425 +/- ##
===========================================
- Coverage 39.08% 39.05% -0.03%
===========================================
Files 748 749 +1
Lines 18647 18647
Branches 1424 1426 +2
===========================================
- Hits 7288 7283 -5
- Misses 11137 11141 +4
- Partials 222 223 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This pull request introduces 1 alert when merging b0eb2d8 into 1431f2e - view on LGTM.com new alerts:
|
filipemarins
force-pushed
the
fix/history
branch
from
b0eb2d8 to
2f8ebf2
Compare
ggazzo
requested changes
Aug 1, 2022
gabriellsh
requested changes
Aug 1, 2022
filipemarins
force-pushed
the
fix/history
branch
from
6b25c5d to
e170e38
Compare
filipemarins
force-pushed
the
fix/history
branch
from
e170e38 to
05f70f7
Compare
Already mentioned here. I added a unit test to this method, I had to use the |
…history * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Cache playwright (#26432) [FIX] Empty results on `im.list` endpoint (#26438) [IMPROVE] Upgrade nivo and React Query (#26338) Chore: Upgrade Fuselage packages to next dist-tag (#26435) Chore: Omnichannel endpoints e2e tests (#26376) Chore: Refactor UserInfo to typescript (#26323) Chore: Rewrite Location modal to React (#26196) Chore: Rewrite SaveToWebdav Modal to React Component (#24365) [IMPROVE] validateParams to accept different validators per request method (#26357) Regression: Fix spacing problem on AppStatus component (#26421) Chore: Convert client/views/account/security folder to ts (#26413) i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336)
gabriellsh
approved these changes
Aug 2, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 9, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Bypass turbo cache on `ui-contexts` (#26526) Chore: Refactor WebdavFilePicker Modal to React Component (#26422) [FIX] Chats holds to load history for some time (#26425) [FIX] Decrypt E2EE messages on thread list (#26133) Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498) Chore: Convert `client/views/account/preferences` folder to ts (#26496)
gabriellsh
added a commit
that referenced
this pull request
Aug 9, 2022
…e/refactor-reportMessage-modal * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Don't wrap wrap up notes (#26375) [IMPROVE] OTR refactoring (#24757) [FIX] Prevent VoIP issues during disconnection when network failed (#26321) Chore: Bypass turbo cache on `ui-contexts` (#26526) Chore: Refactor WebdavFilePicker Modal to React Component (#26422) [FIX] Chats holds to load history for some time (#26425) [FIX] Decrypt E2EE messages on thread list (#26133) Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
sampaiodiego
pushed a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Fix the conditional of wait until wrapper exists function, the
querySelectorreturns anElementwhen the selector is found andnullwhen isn't and doesn't have the propertylength. So the element was not being returned when it was already in the dom.